Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverage gap introduced in PR #1703. #1716

Merged
merged 1 commit into from
Apr 11, 2016
Merged

Fix coverage gap introduced in PR #1703. #1716

merged 1 commit into from
Apr 11, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 11, 2016

No description provided.

@tseaver tseaver added testing api: bigquery Issues related to the BigQuery API. labels Apr 11, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 11, 2016
@dhermes
Copy link
Contributor

dhermes commented Apr 11, 2016

We didn't notice it because coveralls is inconsistent in its reporting?

@dhermes
Copy link
Contributor

dhermes commented Apr 11, 2016

LGTM pending Travis

@tseaver
Copy link
Contributor Author

tseaver commented Apr 11, 2016

We didn't notice it because coveralls is inconsistent in its reporting?

Maybe it was super slow, and somehow things looked green while waiting for it to start?

@tseaver tseaver merged commit cefff49 into googleapis:master Apr 11, 2016
@tseaver tseaver deleted the 1703-fix_coverage_gap branch April 11, 2016 21:04
@daspecster daspecster mentioned this pull request Apr 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot